Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build of MacOS app bundle NanoVNASaver.app #634

Merged
merged 3 commits into from
May 5, 2023
Merged

Build of MacOS app bundle NanoVNASaver.app #634

merged 3 commits into from
May 5, 2023

Conversation

crisobal
Copy link
Contributor

@crisobal crisobal commented May 3, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • Added an icon set for MacOS
  • Addes a build script to build an app bundle locally
  • Added a workflow action to release a NanoVNASaver.app-x86_64.tar.gz artifact

Issue Number: N/A

What is the new behavior?

New Build scripts

Does this introduce a breaking change?

  • Yes
  • No

Other information

Local build script also works for Apple M1 and M2 based Macs. Unfortunately there is no action runner for arm64 based MacOS on github

@crisobal crisobal requested a review from zarath as a code owner May 3, 2023 12:35
zarath
zarath approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@zarath zarath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@zarath zarath merged commit aab2a15 into NanoVNA-Saver:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarath zarath zarath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisobal @zarath